nrt_observation table column name change and added new columns. #48

ssathiah · 2024-10-18T14:28:27Z

Notes

Please include a summary of the change and which issue is fixed or which feature is added.

JIRA

Related story: Jira Ticket

Checklist

PR focuses on a single story.
New unit tests added and ensured they pass.
Service has been tested in local and it works as expected.
Documentation has been updated for this code change (if needed).
Code follows the Java Coding Conventions (https://www.oracle.com/java/technologies/javase/codeconventions-programmingpractices.html).

Types of changes

What types of changes does this PR introduces?

Bugfix
New feature
Breaking change

Testing

Does this PR has >90% code coverage?
Is the screenshot attached for code coverage?
Does the gradle build pass in your local?
Is the gradle build logs attached?

...a-poll-service/src/main/java/gov/cdc/nnddatapollservice/rdbmodern/dto/NrtObservationDto.java

nnd-data-poll-service/src/main/resources/sql/rdb_modern/create_rdb_modern_table.sql

upasanapattnaik-eq

LGTM! Thank you so so much.

...ice/src/main/java/gov/cdc/nnddatapollservice/repository/rdb_modern/model/NrtObservation.java

nnd-data-poll-service/src/main/resources/sql/rdb_modern/create_rdb_modern_table.sql

sonarcloud · 2024-10-18T15:24:46Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nrt_observation table column name change and added new columns.

6666aa2

upasanapattnaik-eq reviewed Oct 18, 2024

View reviewed changes

...a-poll-service/src/main/java/gov/cdc/nnddatapollservice/rdbmodern/dto/NrtObservationDto.java Show resolved Hide resolved

upasanapattnaik-eq reviewed Oct 18, 2024

View reviewed changes

nnd-data-poll-service/src/main/resources/sql/rdb_modern/create_rdb_modern_table.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq approved these changes Oct 18, 2024

View reviewed changes

Formatted the code.

a96196a

sveselev reviewed Oct 18, 2024

View reviewed changes

...ice/src/main/java/gov/cdc/nnddatapollservice/repository/rdb_modern/model/NrtObservation.java Show resolved Hide resolved

sveselev reviewed Oct 18, 2024

View reviewed changes

nnd-data-poll-service/src/main/resources/sql/rdb_modern/create_rdb_modern_table.sql Show resolved Hide resolved

Updated for missing fields to set values from dto

d42b510

ssathiah requested a review from sveselev October 18, 2024 16:20

sveselev approved these changes Oct 18, 2024

View reviewed changes

ssathiah merged commit 9ac7240 into main Oct 18, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nrt_observation table column name change and added new columns. #48

nrt_observation table column name change and added new columns. #48

ssathiah commented Oct 18, 2024

upasanapattnaik-eq left a comment

sonarcloud bot commented Oct 18, 2024

nrt_observation table column name change and added new columns. #48

nrt_observation table column name change and added new columns. #48

Conversation

ssathiah commented Oct 18, 2024

Notes

JIRA

Checklist

Types of changes

Testing

upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 18, 2024

Quality Gate passed